08-25-2022, 12:11 AM
I had that just last month. Did the code review, saw a bunch of potential problems, showed this person best practices for correcting them and sent them on their way. I rejected their pull request 3 freaking times because they kept doing the same stupid thing over and over again. By the 4th request it wasn't broken, but it wasn't good and I said screw it and let them merge it in. I'd refactor it later since it'd only take about 2 minutes instead of half a day of rejecting pull requests...